Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sei composite multiparticle #4693

Draft
wants to merge 14 commits into
base: develop
Choose a base branch
from
Draft

Sei composite multiparticle #4693

wants to merge 14 commits into from

Conversation

aabills
Copy link
Contributor

@aabills aabills commented Dec 18, 2024

Description

make sei work with particle size distributions

Fixes # (issue)

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python -m pytest (or $ nox -s tests)
  • The documentation builds: $ python -m pytest --doctest-plus src (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ nox -s quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@codecov Codecov
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 79.47020% with 31 lines in your changes missing coverage. Please review.

Project coverage is 99.08%. Comparing base (864388f) to head (83264a1).
Report is 8 commits behind head on develop.

Files with missing lines Patch % Lines
.../pybamm/parameters/size_distribution_parameters.py 38.09% 13 Missing ⚠️
src/pybamm/expression_tree/averages.py 63.15% 7 Missing ⚠️
.../submodels/active_material/base_active_material.py 60.00% 4 Missing ⚠️
src/pybamm/geometry/battery_geometry.py 66.66% 2 Missing ⚠️
src/pybamm/parameters/geometric_parameters.py 71.42% 2 Missing ⚠️
...ybamm/models/submodels/interface/base_interface.py 93.33% 1 Missing ⚠️
...s/submodels/interface/total_interfacial_current.py 75.00% 1 Missing ⚠️
.../pybamm/models/submodels/porosity/base_porosity.py 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #4693      +/-   ##
===========================================
- Coverage    99.21%   99.08%   -0.14%     
===========================================
  Files          302      302              
  Lines        22880    22996     +116     
===========================================
+ Hits         22701    22786      +85     
- Misses         179      210      +31

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kratman kratman Awaiting requested review from kratman kratman will be requested when the pull request is marked ready for review kratman is a code owner

@arjxn-py arjxn-py Awaiting requested review from arjxn-py arjxn-py will be requested when the pull request is marked ready for review arjxn-py is a code owner

@agriyakhetarpal agriyakhetarpal Awaiting requested review from agriyakhetarpal agriyakhetarpal will be requested when the pull request is marked ready for review agriyakhetarpal is a code owner

@Saransh-cpp Saransh-cpp Awaiting requested review from Saransh-cpp Saransh-cpp will be requested when the pull request is marked ready for review Saransh-cpp is a code owner

@brosaplanella brosaplanella Awaiting requested review from brosaplanella brosaplanella will be requested when the pull request is marked ready for review brosaplanella is a code owner

@DrSOKane DrSOKane Awaiting requested review from DrSOKane DrSOKane will be requested when the pull request is marked ready for review DrSOKane is a code owner

@rtimms rtimms Awaiting requested review from rtimms rtimms will be requested when the pull request is marked ready for review rtimms is a code owner

@valentinsulzer valentinsulzer Awaiting requested review from valentinsulzer valentinsulzer will be requested when the pull request is marked ready for review valentinsulzer is a code owner

@TomTranter TomTranter Awaiting requested review from TomTranter TomTranter will be requested when the pull request is marked ready for review TomTranter is a code owner

@martinjrobins martinjrobins Awaiting requested review from martinjrobins martinjrobins will be requested when the pull request is marked ready for review martinjrobins is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aabills